git » nextcloud-client.git » commit cf8b628

disable bulk upload capability

author Caleb Maclennan
2022-03-19 09:11:43 UTC
committer Caleb Maclennan
2022-03-19 09:11:43 UTC
parent 43c94470395e3ceeafacfa35b320b3148420f7a5

disable bulk upload capability

PKGBUILD +8 -4

diff --git a/PKGBUILD b/PKGBUILD
index bba7fb8..2de406a 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -14,7 +14,7 @@ epoch=2
 pkgver=3.4.4
 # curl https://api.github.com/repos/nextcloud/desktop/git/ref/tags/v$pkgver | jq -r .object.sha
 _tag=3f54326388167766db182c46ab2d310b710881be
-pkgrel=1
+pkgrel=2
 arch=(x86_64)
 url='https://nextcloud.com/'
 license=(GPL)
@@ -42,10 +42,14 @@ prepare() {
   # tmpdir for check()
   mkdir -p tmpdir
   cd $pkgbase
-  # Monkey patch that can work around infinite loop when using bulk upload
-  # feature, also disabled in server v23.0.3
+  # Monkey patch that disables bulk upload capability which causes infinite
+  # loops for many server/client combos. Feature is also disabled by default on
+  # server end in v23.0.3 because it was so problematic. This can abe re-enabled
+  # when underlying bug squashed:
   # https://github.com/nextcloud/desktop/issues/4241
-  # sed -i -e '221s/_.*/false;/' src/libsync/capabilities.cpp
+  sed -i -e '/bulkupload/s/return _.*;$/return false;/' src/libsync/capabilities.cpp
+  # Disable tests that touch on disabled feature
+  sed -i -e '/SyncEngine/s/^/#/' -e '/Capabilities/s/^/#/' test/CMakeLists.txt
 }
 
 build() {