git » plasma-framework.git » commit fccb58c

Fix occasional empty applet config pages (FS#45350)

author Antonio Rojas
2015-06-17 19:44:51 UTC
committer Antonio Rojas
2015-06-17 19:44:51 UTC
parent 26971164653663a5df50801d516dfb591d61b876

Fix occasional empty applet config pages (FS#45350)

PKGBUILD +8 -3
applet-config.patch +29 -0

diff --git a/PKGBUILD b/PKGBUILD
index 4bab313..ebd7504 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -3,7 +3,7 @@
 
 pkgname=plasma-framework
 pkgver=5.11.0
-pkgrel=1
+pkgrel=2
 pkgdesc='Plasma library and runtime components based upon KF5 and Qt5'
 arch=('i686' 'x86_64')
 url='https://projects.kde.org/projects/frameworks/plasma-framework'
@@ -11,11 +11,16 @@ license=('LGPL')
 depends=('qt5-quickcontrols' 'kactivities-frameworks')
 makedepends=('extra-cmake-modules' 'qt5-tools' 'kdoctools')
 groups=('kf5')
-source=("http://download.kde.org/stable/frameworks/${pkgver%.*}/${pkgname}-${pkgver}.tar.xz")
-md5sums=('de179500e7536dadd33a4b4b3a5f9ed1')
+source=("http://download.kde.org/stable/frameworks/${pkgver%.*}/${pkgname}-${pkgver}.tar.xz" 'applet-config.patch')
+md5sums=('de179500e7536dadd33a4b4b3a5f9ed1'
+         'e9ed934d2f52a6919611d650c3c60671')
 
 prepare() {
   mkdir -p build
+
+# Fix occasional empty applet config pages
+  cd $pkgname-$pkgver
+  patch -p1 -i "$srcdir"/applet-config.patch
 }
 
 build() {
diff --git a/applet-config.patch b/applet-config.patch
new file mode 100644
index 0000000..35fcb46
--- /dev/null
+++ b/applet-config.patch
@@ -0,0 +1,29 @@
+From: Kai Uwe Broulik <kde@privat.broulik.de>
+Date: Wed, 17 Jun 2015 16:28:12 +0000
+Subject: Ignore invalid X-Plasma-ConfigPlugins
+X-Git-Url: http://quickgit.kde.org/?p=plasma-framework.git&a=commitdiff&h=ac04b5570a4072dcb0365387bc739c870a68fe65
+---
+Ignore invalid X-Plasma-ConfigPlugins
+
+CHANGELOG: Fix occasional empty applet config pages
+
+CCBUG: 349250
+REVIEW: 124113
+---
+
+
+--- a/src/plasmaquick/configview.cpp
++++ b/src/plasmaquick/configview.cpp
+@@ -145,6 +145,11 @@
+             KPluginLoader loader(KPluginLoader::findPlugin(QLatin1String("kcms/") + kcm));
+             KPluginMetaData md(loader.fileName());
+ 
++            if (!md.isValid()) {
++                qWarning() << "Could not find" << kcm << "specified in X-Plasma-ConfigPlugins";
++                continue;
++            }
++
+             configModel->appendCategory(md.iconName(), md.name(), QString(), loader.fileName());
+         }
+     }
+